Prevent using future dates for LastSenAt and BackoffAt #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanhamlett
force-pushed
the
bugfix/future-dates
branch
2 times, most recently
from
634d704
to
9fdfdd9
Compare
alanhamlett
force-pushed
the
bugfix/future-dates
branch
from
9fdfdd9
to
ec9a897
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## develop #1089 +/- ##
===========================================
+ Coverage 63.00% 63.01% +0.01%
===========================================
Files 383 383
Lines 16508 16514 +6
===========================================
+ Hits 10401 10407 +6
Misses 5539 5539
Partials 568 568
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a users' clock time is changed to the future temporarily, the timestamps saved in
wakatime-internal.cfgcan be accidentally set to a date far in the future. This causes wakatime-cli to stop sending heartbeats until reaching that date in the future.The fix is to never parse backoff or lastSentAt as future dates.